Add support for H2 #1252
Add support for H2 #1252
Conversation
hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/H2Database.java
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/H2Database.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/H2Database.java
Outdated
Show resolved
Hide resolved
| @@ -33,6 +36,9 @@ | |||
|
|
|||
| private static final String DEFAULT_DB = "hreactDB"; | |||
|
|
|||
| @Rule | |||
| public DatabaseSelectionRule rule = DatabaseSelectionRule.skipTestsFor( H2 ); | |||
There was a problem hiding this comment.
This test should also work for H2. I think it will if you implement createJdbcUrl correctly
There was a problem hiding this comment.
Our Vertx supported DB's all use the DefaultSqlClientPoolConfiguration.connectOptions() method. SqlConnectOptions requires a host and port, so for H2, it would mean coding around these checks.
In H2SqlClientPool I'm using a local SqlConnectOptions object, but I don't need to. Since this class is isolated and uses vertx-jdbc-client JDBCConnectOptions anyway I think it might be better to not use SqlConnectOptions for H2.
There was a problem hiding this comment.
Since this test uses DefaultSqlClientPool and DefaultSqlClientPoolConfiguration().connectOptions( uri ) which are specific to non-H2 Db's I think it still makes sense to skip H2 dbtype
There was a problem hiding this comment.
We can update the test so that it works for both, though. Anyway, ok, let's fix everything else first
hibernate-reactive-core/src/test/java/org/hibernate/reactive/WrongCredentialsTest.java
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/H2SqlClientPool.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutinyExceptionsTest.java
Show resolved
Hide resolved
blafond
force-pushed
the
issue_929
branch
2 times, most recently
from
640613e
to
fe8ede8
Compare
...ive-core/src/main/java/org/hibernate/reactive/pool/impl/ReactiveConnectionPoolInitiator.java
Outdated
Show resolved
Hide resolved
|
Nice to see progress on this :) thanks @blafond ! |
blafond
force-pushed
the
issue_929
branch
2 times, most recently
from
502efa7
to
0c63496
Compare
|
We are putting this on hold because the build fails randomly with |
|
I'm going to send a new PR |
Fixes #929
Added custom H2 client pool and configuration changes to test against an H2 database